[Merged by Bors] - Fix swallowing ActiveSet creation errors during updates #5924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5924 +/- ##
=========================================
- Coverage 80.7% 80.6% -0.1%
=========================================
Files 289 289
Lines 29868 29871 +3
=========================================
- Hits 24107 24102 -5
- Misses 4164 4172 +8
Partials 1597 1597 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
May 10, 2024
|
@poszu agree, will try to improve that at some point |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 10, 2024
## Motivation When processing an update and creating an ActiveSets, database related errors could be swallowed
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 10, 2024
## Motivation When processing an update and creating an ActiveSets, database related errors could be swallowed
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 10, 2024
## Motivation When processing an update and creating an ActiveSets, database related errors could be swallowed
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When processing an update and creating an ActiveSets, database related errors could be swallowed
Description
Provide proper error handling for ActiveSet creation
Test Plan
Tested on a mainnet node