Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Fix activeset weight calc performance in the proposal handler (#5923) #5931

Merged
merged 2 commits into from
May 13, 2024

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented May 13, 2024

Description

Backport of #5923

Proposal handler may cause high CPU and memory usage.
Backport of #5923.
@ivan4th ivan4th changed the base branch from develop to v1.5 May 13, 2024 12:00
@fasmat fasmat enabled auto-merge (squash) May 13, 2024 15:39
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 89.06250% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 80.5%. Comparing base (c1f9fb7) to head (fbac2bf).
Report is 6 commits behind head on v1.5.

Files Patch % Lines
proposals/handler.go 89.0% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            v1.5   #5931    +/-   ##
======================================
  Coverage   80.4%   80.5%            
======================================
  Files        285     286     +1     
  Lines      29579   29771   +192     
======================================
+ Hits       23804   23983   +179     
+ Misses      4168    4166     -2     
- Partials    1607    1622    +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat merged commit e5f0daf into v1.5 May 13, 2024
20 checks passed
@fasmat fasmat deleted the backport-5923 branch May 13, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants