[Merged by Bors] - Fix timing out querying proof in 1:N in presence of a broken Poet

[poszu]

Motivation

Description

Moved the context with deadline creation before locking the mutex. This way, all callers have the same timeout, instead of:

• first: timeout
• second: 2x timeout
• third: 3x timeout

💡 It's arguable whether the deadline should be defined in the Proof() method, or by the caller of it. Placing it in the Proof() method is easier to test, hence I kept it there.

Test Plan

Added a test that verifies N concurrent calls to poetClient.Proof() all end within config.RequestTimeout +- <100ms error margin>.

TODO

• Explain motivation or link existing issue(s)
• Test changes and document test plan
• Update documentation as needed
• Update changelog as needed

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.8%. Comparing base (898c935) to head (defbfed).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #5943   +/-   ##
=======================================
  Coverage     80.7%   80.8%           
=======================================
  Files          288     288           
  Lines        29894   29894           
=======================================
+ Hits         24147   24157   +10     
+ Misses        4159    4153    -6     
+ Partials      1588    1584    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fasmat]

Yes I also think the caller of Proof should probably set the timeout, but I don't insist on it.

[poszu]

bors merge

[spacemesh-bors]

Build failed:

• systest-status

[poszu]

bors merge

[spacemesh-bors]

Pull request successfully merged into develop.

Build succeeded:

• ci-status
• systest-status