Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update tortoise package to use zap directly #5976

Closed
wants to merge 3 commits into from

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented May 23, 2024

Motivation

In this PR the custom log.Log is replaced by zap.Logger in the tortoise package.

Description

Only logging was updated, no functional changes to the package

Test Plan

existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 51.35135% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 81.0%. Comparing base (f9b4108) to head (b868dba).

Files Patch % Lines
tortoise/sim/state.go 14.2% 6 Missing ⚠️
tortoise/sim/layer.go 0.0% 5 Missing ⚠️
datastore/store.go 40.0% 3 Missing ⚠️
tortoise/tortoise.go 66.6% 3 Missing ⚠️
tortoise/model/core.go 50.0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #5976     +/-   ##
=========================================
+ Coverage     80.8%   81.0%   +0.2%     
=========================================
  Files          292     292             
  Lines        30654   30660      +6     
=========================================
+ Hits         24783   24857     +74     
+ Misses        4236    4169     -67     
+ Partials      1635    1634      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat
Copy link
Member Author

fasmat commented May 23, 2024

bors merge

@spacemesh-bors
Copy link

Canceled.

@fasmat
Copy link
Member Author

fasmat commented May 23, 2024

bors merge

@spacemesh-bors
Copy link

Synchronization error!

@fasmat
Copy link
Member Author

fasmat commented May 23, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 23, 2024
## Motivation

In this PR the custom `log.Log` is replaced by `zap.Logger` in the `tortoise` package.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Update tortoise package to use zap directly [Merged by Bors] - Update tortoise package to use zap directly May 23, 2024
@spacemesh-bors spacemesh-bors bot closed this May 23, 2024
@spacemesh-bors spacemesh-bors bot deleted the use-zap-in-tortoise branch May 23, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants