-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Update tortoise package to use zap directly #5976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
force-pushed
the
use-zap-in-tortoise
branch
from
May 23, 2024 15:14
12bcb9f
to
e2c4ef1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5976 +/- ##
=========================================
+ Coverage 80.8% 81.0% +0.2%
=========================================
Files 292 292
Lines 30654 30660 +6
=========================================
+ Hits 24783 24857 +74
+ Misses 4236 4169 -67
+ Partials 1635 1634 -1 ☔ View full report in Codecov by Sentry. |
poszu
approved these changes
May 23, 2024
bors merge |
Canceled. |
bors merge |
Synchronization error! |
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 23, 2024
## Motivation In this PR the custom `log.Log` is replaced by `zap.Logger` in the `tortoise` package.
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Update tortoise package to use zap directly
[Merged by Bors] - Update tortoise package to use zap directly
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In this PR the custom
log.Log
is replaced byzap.Logger
in thetortoise
package.Description
Only logging was updated, no functional changes to the package
Test Plan
existing tests pass
TODO