Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - p2p: server: use zap for logging #5979

Closed
wants to merge 3 commits into from

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented May 24, 2024

Motivation

Use zap for logging in p2p/server instead of the custom logger.
One of the minor changes needed for syncv2

Description

Minor refactor

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 54.28571% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 81.0%. Comparing base (f2770a4) to head (72f33ea).
Report is 29 commits behind head on develop.

Files Patch % Lines
p2p/server/server.go 52.9% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #5979     +/-   ##
=========================================
+ Coverage     80.7%   81.0%   +0.2%     
=========================================
  Files          288     292      +4     
  Lines        29894   30700    +806     
=========================================
+ Hits         24149   24886    +737     
- Misses        4158    4178     +20     
- Partials      1587    1636     +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

p2p/server/server_test.go Outdated Show resolved Hide resolved
Co-authored-by: Matthias Fasching <5011972+fasmat@users.noreply.github.com>
@ivan4th
Copy link
Contributor Author

ivan4th commented May 24, 2024

bors merge

@spacemesh-bors
Copy link

Canceled.

@ivan4th
Copy link
Contributor Author

ivan4th commented May 24, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 24, 2024
## Motivation

Use `zap` for logging in `p2p/server` instead of the custom logger.
One of the minor changes needed for syncv2



Co-authored-by: Ivan Shvedunov <ivan4th@users.noreply.github.com>
@spacemesh-bors
Copy link

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request May 24, 2024
## Motivation

Use `zap` for logging in `p2p/server` instead of the custom logger.
One of the minor changes needed for syncv2



Co-authored-by: Ivan Shvedunov <ivan4th@users.noreply.github.com>
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title p2p: server: use zap for logging [Merged by Bors] - p2p: server: use zap for logging May 24, 2024
@spacemesh-bors spacemesh-bors bot closed this May 24, 2024
@spacemesh-bors spacemesh-bors bot deleted the fix/p2p-server-zap branch May 24, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants