[Merged by Bors] - p2p: server: use zap for logging #5979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
approved these changes
May 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5979 +/- ##
=========================================
+ Coverage 80.7% 81.0% +0.2%
=========================================
Files 288 292 +4
Lines 29894 30700 +806
=========================================
+ Hits 24149 24886 +737
- Misses 4158 4178 +20
- Partials 1587 1636 +49 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
May 24, 2024
fasmat
approved these changes
May 24, 2024
Co-authored-by: Matthias Fasching <5011972+fasmat@users.noreply.github.com>
|
bors merge |
|
Canceled. |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 24, 2024
## Motivation Use `zap` for logging in `p2p/server` instead of the custom logger. One of the minor changes needed for syncv2 Co-authored-by: Ivan Shvedunov <ivan4th@users.noreply.github.com>
|
Build failed (retrying...): |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 24, 2024
## Motivation Use `zap` for logging in `p2p/server` instead of the custom logger. One of the minor changes needed for syncv2 Co-authored-by: Ivan Shvedunov <ivan4th@users.noreply.github.com>
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use
zapfor logging inp2p/serverinstead of the custom logger.One of the minor changes needed for syncv2
Description
Minor refactor