[Merged by Bors] - Don't set atx version in migration 18 #6011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
reviewed
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6011 +/- ##
=======================================
Coverage 81.2% 81.3%
=======================================
Files 296 296
Lines 31496 31498 +2
=======================================
+ Hits 25606 25620 +14
+ Misses 4215 4205 -10
+ Partials 1675 1673 -2 ☔ View full report in Codecov by Sentry. |
fasmat
approved these changes
Jun 5, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
## Motivation Speedup the 18th migration of state the DB.
|
Build failed:
|
This reverts commit 08d6f07.
fasmat
approved these changes
Jun 5, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
## Motivation Speedup the 18th migration of state the DB.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Speedup the 18th migration of state the DB.
Description
The migration takes significant time because it sets
versioncolumn for all existing ATXs and their number is so huge it takes ~30 minutes on fast computers (with nvme drive). Solely adding the column w/o a default value is instant.This change changes the definition of
types.AtxV1from1to0so that we don't need to populate the column at all to have all existing ATXs be V1.Test Plan
TODO