[Merged by Bors] - Skip installation of golangci-lint on windows runners #6021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6021 +/- ##
=======================================
Coverage 81.3% 81.3%
=======================================
Files 296 296
Lines 31672 31672
=======================================
+ Hits 25769 25781 +12
+ Misses 4222 4211 -11
+ Partials 1681 1680 -1 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Jun 7, 2024
fasmat
approved these changes
Jun 7, 2024
fasmat
changed the title
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
## Motivation Fix some issues we had on the GH Actions Co-authored-by: Matthias <5011972+fasmat@users.noreply.github.com>
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
poszu
reviewed
Jun 10, 2024
Comment on lines
+60
to
+65
| ifneq ($(OS),Windows_NT) | ||
| # On GH windows runners this fails at the moment: https://github.com/actions/runner-images/issues/10009 | ||
| # since we don't run the linter on windows in the CI, we can skip this step for now | ||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s $(GOLANGCI_LINT_VERSION) | ||
| endif | ||
|
|
There was a problem hiding this comment.
@fasmat It's not only used in CI but also by devs on Windows (IDK if there is anybody developing on Windows at present). Now make lint will fail with "command not found" error for them...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix some issues we had on the GH Actions
Description
This PR solves the issue with the git checkout on the windows runner and the installation of the golangci/lint on windows too.
Test Plan
Run the CI workflow