Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use zap in checkpoint package #6063

Closed
wants to merge 1 commit into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jun 23, 2024

Motivation

Continue migration from our log implementation to zap.

Description

Migrate the checkpoint package to zap.

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.4%. Comparing base (1be211b) to head (964ff14).

Files Patch % Lines
checkpoint/recovery.go 94.7% 2 Missing ⚠️
node/node.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6063     +/-   ##
=========================================
- Coverage     81.4%   81.4%   -0.1%     
=========================================
  Files          299     299             
  Lines        32171   32149     -22     
=========================================
- Hits         26212   26193     -19     
+ Misses        4247    4245      -2     
+ Partials      1712    1711      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu
Copy link
Contributor Author

poszu commented Jun 24, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jun 24, 2024
## Motivation

Continue migration from our log implementation to zap.
@spacemesh-bors
Copy link

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request Jun 24, 2024
## Motivation

Continue migration from our log implementation to zap.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Use zap in checkpoint package [Merged by Bors] - Use zap in checkpoint package Jun 24, 2024
@spacemesh-bors spacemesh-bors bot closed this Jun 24, 2024
@spacemesh-bors spacemesh-bors bot deleted the refactor/use-zap-in-checkpoint-pkg branch June 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants