Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Increase keep-alive interval to 10min #227

Merged
merged 2 commits into from Mar 26, 2024

Conversation

poszu
Copy link
Collaborator

@poszu poszu commented Mar 26, 2024

The 1-minute interval is too low and caused the server side to eventually respond with GOAWAY and close the connection with "too many pings" message.

@poszu poszu requested a review from fasmat March 26, 2024 09:59
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (aea8a6f) to head (565eb29).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          26       26           
  Lines        3376     3376           
=======================================
  Hits         3171     3171           
  Misses        205      205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu merged commit 7a6ef53 into main Mar 26, 2024
20 checks passed
@poszu poszu deleted the increase-keep-alive-interval branch March 26, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants