Fix race between Close and Verify of postrs.Verifier #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fasmat
force-pushed
the
fix-race-verifier
branch
from
49fa326
to
bc06d3f
Compare
poszu
approved these changes
Sep 7, 2023
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Sep 7, 2023
## Motivation Closes #4910, merge after spacemeshos/post#232. ## Changes - Removed `Start` method, a verifier returned from `NewOffloadingPostVerifier` is ready to be used - `Close` cancels ongoing verifications and avoids new ones being started - Updated `node.go` to use the new API ## Test Plan - existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Sep 7, 2023
## Motivation Closes #4910, merge after spacemeshos/post#232. ## Changes - Removed `Start` method, a verifier returned from `NewOffloadingPostVerifier` is ready to be used - `Close` cancels ongoing verifications and avoids new ones being started - Updated `node.go` to use the new API ## Test Plan - existing tests pass ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of spacemeshos/go-spacemesh#4910
Both methods are not protected by a mutex, additionally this ensures that no segfaults are triggered when:
Closeis called twiceVerifyis called after the verifier is closed (instead it now returns an error)