Add Transactions doc #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
lrettig
commented
Feb 7, 2020
|
I filled out as much as I could based on the gdoc and my knowledge. Over to @noamnelke and @moshababo and @avive for review - maybe you guys can flesh this out a bit more! |
lrettig
moved this from In progress
to PR ready for review
in Open source readiness wikidocs
noamnelke
requested changes
Feb 10, 2020
noamnelke
reviewed
Feb 11, 2020
|
My edits are done. @noamnelke back to you sir! |
lrettig
moved this from PR ready for review
to PR review in progress
in Open source readiness wikidocs
barakshani
reviewed
Feb 14, 2020
barakshani
reviewed
Feb 14, 2020
Clarify a bunch of things based on helpful feedback from @barakshani and @noamnelke
Requires #26
Address uses pubkey suffix not prefix Co-Authored-By: Noam Nelke <NoamNelke@gmail.com>
Github web merge ftw 🤦♂
Update references to public key extraction, fee+subsidy distribution per Barak, Noam comments
per thread with @barakshani
It's not relevant or interesting to know here how the public key is derived from the private key. It's just a keypair :) And the rest should be abstracted from the developer.
With helpful feedback from @barakshani
Add a new section on mining/assembling blocks and consolidate all content related to this. Add info on how blocks are assembled, and rework description of contextual validity.
Per noam suggestion
noamnelke
approved these changes
Mar 30, 2020
Based on info from @noamnelke. Move the fees and rewards section to the end to make the flow clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6