Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FFI function to read pubkey from Ledger #4

Merged
merged 12 commits into from
May 13, 2023
Merged

Add FFI function to read pubkey from Ledger #4

merged 12 commits into from
May 13, 2023

Conversation

lrettig
Copy link
Member

@lrettig lrettig commented May 8, 2023 •
edited

Also some misc. cleanup and refactoring: add common package for shared utils

@lrettig lrettig requested a review from fasmat May 8, 2023 18:27
fasmat
fasmat reviewed May 8, 2023
View reviewed changes
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #5 because otherwise it would have been too many comments in this PR.

common/ffitools.go Outdated Show resolved Hide resolved
fasmat
fasmat reviewed May 8, 2023
View reviewed changes
bip32/bip32.go Outdated Show resolved Hide resolved
remote-wallet/remote_wallet.go Outdated Show resolved Hide resolved
@lrettig
Update upstream dependency path
f339328
@lrettig
Refactoring and improvements based on review
8ca2bd1 
Remove common module
Pass pre-allocated bytearray across FFI boundary and check return status
code
Remove hardcoded C headers
Testing still WIP
Thanks Mafa!
@lrettig
Move CGO config into env in Makefile
f9f7bb3
@lrettig
Pass strings over FFI as CString
15e5e90
@lrettig lrettig requested a review from fasmat May 10, 2023 19:17
@lrettig lrettig mentioned this pull request May 10, 2023
Merged
fasmat
fasmat reviewed May 11, 2023
View reviewed changes
Makefile Show resolved Hide resolved
fasmat
fasmat reviewed May 11, 2023
View reviewed changes
bip32/bip32.go Outdated Show resolved Hide resolved
@lrettig lrettig mentioned this pull request May 11, 2023
Closed
@lrettig lrettig requested a review from fasmat May 11, 2023 19:06
@lrettig lrettig merged commit bc868fb into main May 13, 2023
1 check passed
@lrettig lrettig deleted the ledger branch May 13, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasmat fasmat fasmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lrettig @fasmat