This repository has been archived by the owner on Aug 14, 2023. It is now read-only.
add capacity to svm_byte_array
#185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshababo
force-pushed
the
byte_arr_cap
branch
2 times, most recently
from
5b446dd
to
dd61def
Compare
moshababo
force-pushed
the
byte_arr_cap
branch
from
dd61def
to
0213b28
Compare
YaronWittenstein
approved these changes
Nov 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
capacitytosvm_byte_array(the total number of allocated bytes).It may be unequal and bigger than
lengthif thesvm_byte_arrayinstance is an alias to an instance of a data structure such asVec(which in order to properly get deallocated needs first to be re-constructed using the proper allocated capacity).Vec#leak wasn't used because in order to remove the surplus capacity it clones the data, while
svm_byte_arrayis intended to be an alias.Closing #129.