Resources tracking #188

YaronWittenstein · 2020-11-24T17:09:52Z

Motivation

The motivation of this PR is to numerically track the number of live instances (by type) manually allocated (on the heap).

There are lots of manual memory allocations, especially in the FFI context which could result in memory leaks if not handled correctly.

* WIP: Wasmer FFI export

…pi`).

…s after host function completion).

… the structs defined under `svm-ffi`.

…y `svm.h` (at the `svm-runtime-c-api` crate).

…asm_values`

…ay`.

…s` crate.

moshababo

Good stuff!

crates/svm-ffi/src/tracking/interning.rs

crates/svm-ffi/src/tracking/snapshot.rs

crates/svm-runtime-c-api/src/api.rs

crates/svm-ffi/src/tracking/snapshot.rs

crates/svm-runtime/src/import.rs

crates/svm-runtime/src/runtime/ptr.rs

YaronWittenstein added 30 commits November 15, 2020 20:57

* updating crates

81ef898

* WIP: Wasmer FFI export

WIP: supporting runtime Host imports for SVM (for testing).

5d893ee

WIP

601feb3

svm-runtime: Import isn't Clone anymore.

6c3803f

DefaultRuntime refinements.

652cfb4

WIP

116a608

WIP

48a454b

Each external import may have its own host_env

69023b5

c-api: tests contains assertions agains Receipt's returndata.

0ed6de5

Releasing allocated memory of svm_env_t after usage.

3703eec

Adding some documentation

5ef8b38

Some more documentation

ef1f98b

Created a new crate named svm-ffi (moved code from `svm-runtime-c-a…

8143033

…pi`).

Removed the tests of svm-sdk-macros (obsolete code).

723ecd7

Merge from master (svm-ffi)

d52d829

tests pass.

4876b09

svm-runtime is now independent of wasmer-c-api

45ed698

WIP: making svm-runtime-c-api tests work against the recent changes.

139b8aa

tests pass.

cfa46af

svm-runtime: zero-allocated host functions' results (and deallocate…

2404be6

…s after host function completion).

Adding a doc-test for svm_ffi::alloc_wasm_values.

bfb56a8

Added a doc-test for svm_byte_array#copy_wasm_values

f1d5a82

Adding 2 more doc-tests for svm_byte_array#copy_wasm_values.

f0f503d

WIP: trying to make cbindgen output of svm-runtime-c-api to include…

74a1a60

… the structs defined under `svm-ffi`.

svm-ffi generates an header file (svm_types.h) that is included b…

39bb260

…y `svm.h` (at the `svm-runtime-c-api` crate).

typo

a3eba35

tests pass.

72af45f

import - wrapper callback allocates results using `svm_ffi::alloc_w…

330bca2

…asm_values`

Import is using Rc for shallow-cloning of returns types.

0c8bd74

changes for PR comments.

2e0ffb4

YaronWittenstein added 17 commits November 29, 2020 15:39

WIP

f4c8528

WIP

b06fdf6

WIP

6da9f7d

WIP

0159bc9

Enforcing attaching a TypeIdOrStr while converting to `svm_byte_arr…

8b8dfe1

…ay`.

WIP: tracking manual resources allocation

c2deb64

WIP

aa55d88

WIP

468c9f8

tests pass.

43d380a

Renamed TypeIdOrStr to Type and moved from svm-ffi to `svm-type…

0d43c3a

…s` crate.

WIP: refactoring svm-ffi tracking module.

646d116

runtime-c-api: exposing manually-allocated resources tracking API.

686893b

Adding more pieces to the resources tracking.

2b09655

svm-ffi: refining the tracking module.

0f489e9

WIP: running resources tracking tests safely.

f76809d

WIP

5b7753a

getting closer to PR readiness.

a67c30d

YaronWittenstein marked this pull request as ready for review December 2, 2020 20:42

YaronWittenstein added 3 commits December 3, 2020 15:46

svm-ffi - adding missing docs.

6bf68f8

WIP

1d0a8c0

test pass.

5f44f15

moshababo reviewed Dec 4, 2020

View reviewed changes

YaronWittenstein added 4 commits December 6, 2020 13:50

PR fixes: fixing the error deallocation when host function traps.

7bcee0c

tracking/snapshot.rs - more documentation.

16cb7b0

small comment

6c20114

typo

d61a57c

moshababo approved these changes Dec 6, 2020

View reviewed changes

tracking/interning.rs - explaining why we use interning.

d4412ae

YaronWittenstein merged commit 8981880 into master Dec 6, 2020

YaronWittenstein deleted the resources-tracking branch December 6, 2020 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resources tracking #188

Resources tracking #188

YaronWittenstein commented Nov 24, 2020 •

edited

moshababo left a comment

Resources tracking #188

Resources tracking #188

Conversation

YaronWittenstein commented Nov 24, 2020 • edited

Motivation

moshababo left a comment

Choose a reason for hiding this comment

YaronWittenstein commented Nov 24, 2020 •

edited