-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
use svm_abi_layout::layout; | ||
|
||
#[test] | ||
fn integer_layouts() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can - please add a few more asserts to the other integer markers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand, what other conditions should I test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more markers that can be asserted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are derived automatically form the 1B
ones using arithmetic. I think all are covered
This is a PR draft to discuss loop unrolling ergonomics in the context of the SVM ABI encoder. Future changes and/or PRs might address the SVM decoder in a similar fashion if we're satisfied with these changes. The underlying tone of the refactor is:
impl
's with type safety using Rust traits. We might have to tweak trait names and implementation algebra a bit more, but I think this looks better and is much simpler to deal with.num-traits
crate.seq-macro
crate.Possible TODOs and further changes to discuss: