Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider styles #5

Closed
ay42 opened this issue Dec 13, 2019 · 0 comments · Fixed by #11
Closed

Slider styles #5

ay42 opened this issue Dec 13, 2019 · 0 comments · Fixed by #11
Assignees

Comments

@ay42
Copy link
Member

ay42 commented Dec 13, 2019

This will enable support for styles to match behaviour of other SwiftUI native elements (Buttons, Pickers, Toggles)

User should be able to specify slider styles.

.valueSliderStyle(...)
.rangeSliderStyle(...)
.pointSliderStyle(...)

This will use makeBody method

func makeBody(configuration: Self.Configuration) -> Self.Body

This will also rename current slider types to

ValueSlider()
RangeSlider()
PointSlider()

with geometry and interactions moving to styles

HorizontalValueSliderStyle() // Default
VerticalValueSliderStyle()
...
@ay42 ay42 self-assigned this Dec 13, 2019
@ay42 ay42 pinned this issue Dec 13, 2019
@ay42 ay42 transferred this issue from spacenation/swiftui-grid Jan 26, 2020
@ay42 ay42 mentioned this issue Mar 13, 2020
@ay42 ay42 closed this as completed in #11 Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant