Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search View #74

Merged
merged 42 commits into from Mar 10, 2019
Merged

Update Search View #74

merged 42 commits into from Mar 10, 2019

Conversation

fbernutz
Copy link
Member

@fbernutz fbernutz commented Mar 3, 2019

  1. This mainly updates the UI in the Search:
    1. There is now a hint when a movie isn't released yet.
    2. The user can now see if a movie is already on one of his lists.
    3. The exact release date is only displayed for the current year.
  2. It is also possible to quickly add movies to one of the lists without the need to open the search again after one action.
  3. The NonClearView is now part of a new SeparatorView which has an orange background as it is the only view where it is needed right now.
  4. The TabBar has now two different icons and another name.
  5. The new layout perfectly supports Dynamic Type and Voice Over.

Screenshots

old new
simulator screen shot - iphone x - 2019-03-03 at 11 09 40 Simulator Screen Shot - iPhone X - 2019-03-09 at 17 03 23
Simulator Screen Shot - iPhone X - 2019-03-09 at 17 05 02 Simulator Screen Shot - iPhone X - 2019-03-09 at 17 06 19

Open ToDos

  • Remove OldSearchCell and update tests
  • Add "Delete"-Swipe Action when a movie is already marked and you want to remove the marker
  • Position Swipe Actions trailing or leading?
  • Think about a relative date information (like "in 2 days") for movies which will be released in the next days
  • Swipe Action Icons pixelated
  • Swipe Action Icon Seen is white and on badge it is black
  • Force Touch Action in Search should refresh UI with badge in Search -> Disabled in search

@fbernutz fbernutz changed the title WIP: Update Search UI Update Search View Mar 10, 2019
@fbernutz fbernutz merged commit 088bdaf into master Mar 10, 2019
@fbernutz fbernutz deleted the new-ui/search branch March 10, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant