DBRunner enhancements for ingest, update-only, force (Closes #9) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Updated DBRunner to take process name as well as process ID on the command line, and fixed up a few bugs I found in the meantime. |
|
Rebased since #24 was merged; this still needs review/merge. |
* Should be no change to functionality.
* --force flag to always bump version. * -u/--update flag to only run for out-of-date files (not there or new code). * This required a fix for runMe's "new parent" check when no inputs. * Also fix rendering of DBRunner script documentation.
* Not functional yet.
* There are new arguments that mean files are made sometimes, not always.
* The actual runMe runner doesn't check this, so if not running in pure-force mode, check it to make sure not making files that conflict with the database.
* 4cc7b44 removed runMe from list if ableToRun was false, test wasn't updated for that.
dnadeau-lanl
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR conflicts with #24, in that it includes everything from #24. Either this can be merged and #24 closed, or when #24 is merged I'll rebase this one to the new master.
This PR enhances DBRunner in several ways:
This closes #9 by implementing the checklist/design there.
I had #24 open to get the testing-related changes out faster and hopefully have them reviewed before I did the functionality here. So if someone has time to review this one, it will get everything...if only a little time, then #24 can come first (and this one will have to wait for the rebase.)
PR Checklist
See issue #orCloses #)