Fix unit tests for scripts #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rewrap expected input * More fine-grained testing so easier to find what's different
* The parsing of the inputs changed to allow for specifying days before/after, and the test was never updated.
* Update addMission to make the parameters optional again * Update addFromConfig and tests to make them optional * This should work with old or new database structure, and old or new config files.
dnadeau-lanl
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tests_scriptsdirectory contains unit tests for the scripts. Unfortunately these hadn't been updated in awhile and were failing. This PR fixes them, as well as making a small change so addFromConfig works properly with older config files (ones that don't explicitly specify code, inspector, and error directories.)