Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_DButils: clarify no-output tests #99

Merged
merged 1 commit into from Nov 22, 2021

Conversation

jtniehof
Copy link
Member

Tiny PR relevant to discussion in #94, to clarifly the zero output product ID in a test is meant to verify the fix didn't introduce a regression, it's not actually a no-output process

PR Checklist

  • Pull request has descriptive title
  • Pull request gives overview of changes
  • New code has inline comments where necessary
  • (N/A) Any new modules, functions or classes have docstrings consistent with dbprocessing style
  • (N/A) Major new functionality has appropriate Sphinx documentation
  • (N/A) Added an entry to release notes if fixing a major bug or providing a major new feature
  • (N/A) New features and bug fixes should have unit tests
  • Relevant issues are linked in the description (use Closes # if this PR closes the issue, or some other reference, such as See # if it is related in some other way)

 * Zero output product ID meant to verify the fix didn't introduce a
   regression, it's not actually a no-output process
@dnadeau-lanl dnadeau-lanl merged commit 34d3cb0 into spacepy:master Nov 22, 2021
@jtniehof jtniehof deleted the nooutput_test_comment branch November 22, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants