Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple GH actions config to make the workflow show up #496

Merged
merged 1 commit into from Jan 26, 2021

Conversation

jtniehof
Copy link
Member

@jtniehof jtniehof commented Jan 26, 2021

A GitHub actions workflow won't show up in the UI until it's merged to master and run a single time. This is a very simple workflow that just checks out the repo and does nothing else, so we can merge it to master and activate the workflow. After that, workflow updates in PRs should run properly, which will allow me to complete #495 and ultimately close #455.

This was tested by merging to master on my fork and verifying the action showed up (then force-pushing to my fork to clean up, which won't be necessary here.)

PR Checklist

  • Pull request has descriptive title
  • Pull request gives overview of changes
  • (N/A) New code has inline comments where necessary
  • (N/A) Any new modules, functions or classes have docstrings consistent with SpacePy style
  • (N/A) Added an entry to CHANGELOG if fixing a major bug or providing a major new feature
  • (N/A) New features and bug fixes should have unit tests
  • Relevant issues are linked to (e.g. See issue # or Closes #)

 * The workflow won't show up in the UI until it's merged to master, so
   this is a very simple workflow that just checks out the repo to
   make this happen.
@jtniehof jtniehof requested a review from drsteve January 26, 2021 20:01
@drsteve drsteve merged commit 991111a into spacepy:master Jan 26, 2021
@jtniehof jtniehof deleted the gh_actions_prime branch January 26, 2021 20:07
@jtniehof
Copy link
Member Author

Oh drat I thought "close" wasn't magic (because "closes" is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI off Travis
2 participants