SPACESHIP_CONFIG_PATH not set correctly

[ksalman]

Is there an existing issue for this?

• Yes, I have searched the existing issues
• Yes, I have checked troubleshooting page

The problem

I created a config file at $HOME/.config/spaceship/spaceship.zsh but it is not loaded. It looks like the path is not loaded correctly here:
https://github.com/spaceship-prompt/spaceship-prompt/blob/master/lib/config.zsh#L11

Instead of:
"${XDG_CONFIG_HOME:="$HOME/.config/spaceship"}/spaceship.zsh"

It should be:
"${XDG_CONFIG_HOME:="$HOME/.config"}/spaceship/spaceship.zsh"

My $XDG_CONFIG_HOME is /Users/ksalman/.config

Here is how the array looks like with the current code. The 3rd and 4th elements are the same

➜ echo $SPACESHIP_CONFIG_PATH
/Users/ksalman/.spaceshiprc /Users/ksalman/.spaceshiprc.zsh /Users/ksalman/.config/spaceship.zsh /Users/ksalman/.config/spaceship.zsh /etc/xdg/spaceship.zsh

Relevant Zsh configuration

irrelevant

What is version of Spaceship are you using?

4.2.1

What is version of Zsh are you using?

zsh 5.8 (x86_64-apple-darwin20.0)

What operation system are you running?

macOS

Do you use any Zsh framework or plugin manager?

No response

Which terminal emulator do you use?

iTerm

Additional information

No response

[denysdovhan]

Good catch! Would you like to send a PR?

[ksalman]

Sure. Will do.

…

On Mon, Sep 5, 2022, at 10:19, Denys Dovhan wrote: Good catch! Would you like to send a PR? — Reply to this email directly, view it on GitHub <#1184 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJVZB7VAPCWQX7PYIFEFNDV4YTTDANCNFSM6AAAAAAQFELO2U>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[denysdovhan]

🎉 This issue has been resolved in version 4.2.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[ksalman]

Thanks for fixing it.