New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SPACESHIP_RPROMPT_ORDER option for RPS1 prompt #168
Conversation
Hi! Thanks for contributing! Could you give us some screenshots how this feature looks like? Also, is this a OMZ feature or ZSH itself? We're going to drop OMZ as dependency. |
Looks like a wonderful feature. Is there anyway to setup both prompts in the same line and commands on the next line ? Like, In the below picture, But with Since we're using @denysdovhan Suggestion ? |
Usually, the right side prompt appears at the end of the very last line of the prompt, no matter how many line_sep involved. There are tricks to manually force it to the end of any desired line (see https://superuser.com/questions/974908/multiline-rprompt-in-zsh ) but there is a risk: the rprompt disappears if it overlaps with anything from the left prompt, so if your terminal width is small or you pack too much into the rprompt, you won't see it at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an official reviewer, but the code does look good.
Let's keep this feature to the next major release. It needs better consideration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of copy-pasting in this. Looks like theme needs some refactoring. Would be great to implement this as a part of 3.0
.
Gonna try to resolve issues, but not sure if it work with |
Just resolved related issues. Works perfectly from |
I like your theme and wanted to suggest RPS1 prompt support to make it even more awesome.