Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SPACESHIP_RPROMPT_ORDER option for RPS1 prompt #168

Merged
merged 1 commit into from Oct 19, 2017
Merged

Added SPACESHIP_RPROMPT_ORDER option for RPS1 prompt #168

merged 1 commit into from Oct 19, 2017

Conversation

ddrexl
Copy link
Contributor

@ddrexl ddrexl commented Jul 9, 2017

I like your theme and wanted to suggest RPS1 prompt support to make it even more awesome.

@salmanulfarzy salmanulfarzy added the new-feature A PR that implement feature (section, specific behavior, etc). label Jul 10, 2017
@denysdovhan
Copy link
Member

Hi! Thanks for contributing!

Could you give us some screenshots how this feature looks like? Also, is this a OMZ feature or ZSH itself? We're going to drop OMZ as dependency.

@ddrexl
Copy link
Contributor Author

ddrexl commented Jul 10, 2017

Hi

The RPS1 prompt is a feature of the ZSH itself.
The example screenshot shows my docker and custom vi-mode on the right side:
spaceship_right_prompt

@salmanulfarzy
Copy link
Member

Looks like a wonderful feature. Is there anyway to setup both prompts in the same line and commands on the next line ? Like, In the below picture, But with char in the next line ?

image

Since we're using line_sep in prompt itself. Above suggestion might depend on the theme implementation.

@denysdovhan Suggestion ?

@ddrexl
Copy link
Contributor Author

ddrexl commented Jul 11, 2017

Usually, the right side prompt appears at the end of the very last line of the prompt, no matter how many line_sep involved. There are tricks to manually force it to the end of any desired line (see https://superuser.com/questions/974908/multiline-rprompt-in-zsh ) but there is a risk: the rprompt disappears if it overlaps with anything from the left prompt, so if your terminal width is small or you pack too much into the rprompt, you won't see it at all.

Copy link
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an official reviewer, but the code does look good.

@denysdovhan
Copy link
Member

Let's keep this feature to the next major release. It needs better consideration.

@denysdovhan denysdovhan added this to the v3.0 milestone Aug 20, 2017
Copy link
Member

@denysdovhan denysdovhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of copy-pasting in this. Looks like theme needs some refactoring. Would be great to implement this as a part of 3.0.

@denysdovhan denysdovhan added the breaking ‼️ BREAKING CHANGES ‼️ All breaking changes go under major release. label Aug 21, 2017
@denysdovhan denysdovhan mentioned this pull request Aug 22, 2017
25 tasks
@denysdovhan denysdovhan changed the base branch from master to 3.0 October 19, 2017 10:54
@denysdovhan denysdovhan merged commit 9b1723c into spaceship-prompt:3.0 Oct 19, 2017
@denysdovhan
Copy link
Member

Gonna try to resolve issues, but not sure if it work with 3.0 implementation of sections.

@denysdovhan
Copy link
Member

Just resolved related issues. Works perfectly from 3.0 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ‼️ BREAKING CHANGES ‼️ All breaking changes go under major release. new-feature A PR that implement feature (section, specific behavior, etc).
Development

Successfully merging this pull request may close these issues.

None yet

4 participants