Add @Runrioter as a maintainer

[denysdovhan]

@Runrioter would you be interested in maintaining this project?

I've burned out. Seems like @salmanulfarzy and @maximbaz don't have much time to lead this project as well. You're one of the leaders in contributors graph, therefore I believe you'd help this project to evolve.

Thanks!

P.S: Don't be afraid, I can answer any question you need.

---

@salmanulfarzy @maximbaz your thoughts?

[denysdovhan]

Also, I'm thinking about moving this project under spaceship-prompt organization, where we can gather all spaceship-way projects, like spaceship-prompt, spacefish, starship.

cc @matchai

[denysdovhan]

I can also grant access to spaceshipzsh twitter account, if needed.

[maximbaz]

sorry to hear you have burned out, hope you'll get some rest and regain productivity!
🙏

I support adding maintainers, I only ask you to define a clearer policy of how you want this to work. For me that was the strongest pullback, I was never sure if I am allowed to actually merge pull requests, for example I didn't feel like I have the power to go for any async implementation, get it to a good point and merge.

I've been using my own fork for a while because of this exact reason, and recently I switched to p10k as it now has a few unique superior features, like "instant prompt" (instant terminal startup), transient segments (segments that appear only when you type a certain command, like typing "az" makes "azure" segment appear), and very interesting strategies for "dir" segment.

To be clear, I'm still happy to help with this project, it has lots of users and there is a clear impact in helping everyone to get a faster and richer prompt!

moving the project to an org could also make sense, there is a "starship" org for example which you and I are part of already anyway 😉

[Runrioter]

@denysdovhan Thank you for your trust. I am interested in maintaining this project as a bug fixer.

It's a pity that you have burned out. I hope you will regain someday with awesome projects.

[denysdovhan]

I only ask you to define a clearer policy of how you want this to work.

You can do whatever you think is right. Let's just keep in mind, that you need to have at least two approvals to get something merged.

UPD: I've added corresponding rule to repo's settings.

[maximbaz]

Hey guys, I'd like to step down as maintainer of spaceship. This project has played a big role for me and I really enjoyed being part of it (thanks to you all!), but I got less time to properly take care of it and as a result I switched to p10k which is being actively maintained without my active involvement, and I hate being the guy who blocks PRs and other improvements in spaceship because of my slow responses. Please feel free to ping me if you'd like some input or feedback, I will gladly reply, it just means I won't be a default PR reviewer.

See you on the Internet 😉

[Runrioter]

@maximbaz It's a pity that you have burned out. I hope you will come back someday.

@denysdovhan Now there are many PRs that are waiting for being merged. But need at least two approvals.

[denysdovhan]

@Runrioter I think you can merge whatever you think is right. You should have administrator rights. Let me know if there is a PR you have doubts about, so we can discuss them.

[Runrioter]

Yes, I agree with you. If I have doubts about some issues, we will discuss them together.

[Runrioter]

Hi @denysdovhan When can I have administrator rights to merge some bugs PR. Thanks in advance.

[denysdovhan]

@Runrioter you should have the same permissions as other collaborators. Can you doublecheck?

[Runrioter]

@denysdovhan Yes I have right to merge PR, but now it seem that it is difficult to make PR get at least two approvals. 😆 So I can not merge any PRs

[denysdovhan]

@Runrioter your and mine approval should be enough isn't it?

[Runrioter]

@denysdovhan Pull request authors can’t approve their own pull request 😭

[denysdovhan]

Pull request authors can’t approve their own pull request 😭

Which is okay. Just request my review for your PRs. Moreover, I downgraded the required approvals to only one approval.

[Runrioter]

OK, please downgraded the required approvals to only one approval. Currently #759 #770 #780 need your review and approval

[github-actions]

🎉 This issue has been resolved in version 3.12.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀