Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Git Display #931

Closed
notkspr opened this issue Apr 18, 2021 · 5 comments
Closed

Enhance Git Display #931

notkspr opened this issue Apr 18, 2021 · 5 comments

Comments

@notkspr
Copy link

notkspr commented Apr 18, 2021

Can we add more details for the git module instead of just putting icons?

I do not understand any of the code of the theme, so I could not give any implementation details.

I recently changed from powerlevel10k, and their git display is more clear to me.
They added numbers to indicate the number of files that you have changed.
Would it be nice if you can include it?

I am aware that this additional information may break the minimalistic style of the theme.

I would give some screenshots to compare both (focus on the git section).

Spaceship
Screenshot 2021-04-18 at 9 48 09 AM

Powerlevel10k
Screenshot 2021-04-18 at 9 47 53 AM

Many thanks!

@notkspr
Copy link
Author

notkspr commented Apr 18, 2021

Update: #890

I found a similar solution that is not merged.

@Muratzero21
Copy link

Muratzero21 commented Apr 18, 2021 via email

@notkspr
Copy link
Author

notkspr commented Apr 18, 2021

I want to examine can you give all the codes 18 Nis 2021 Pzr 4:50 AM tarihinde Kasper-Liu @.***> şunu yazdı:

Can we add more details for the git module instead of just putting icons? I do not understand any of the code of the theme, so I could not give any implementation details. I recently changed from powerlevel10k, and their git display is more clear to me. They added numbers to indicate the number of files that you have changed. Would it be nice if you can include it? I am aware that this additional information may break the minimalistic style of the theme. I would give some screenshots to compare both (focus on the git section). Spaceship [image: Screenshot 2021-04-18 at 9 48 09 AM] https://user-images.githubusercontent.com/65485161/115131518-4ebd5180-a02b-11eb-89b8-2b130228e932.png Powerlevel10k [image: Screenshot 2021-04-18 at 9 47 53 AM] https://user-images.githubusercontent.com/65485161/115131519-50871500-a02b-11eb-9b50-a495325880a1.png Many thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#931>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM72X4YACZDYITA4A5MHABTTJI3FNANCNFSM43DVSC6Q .

Frankly, I cannot give the code to you because I don't even know how to implement it honestly.

@rrobertobt
Copy link

If you want easier customization, I would strongly recommend you to check out the starship prompt, which is basically the same but is cross-shell compatible and is configured with a config file, here's what mine looks like:

Screenshot from 2021-04-23 20-39-26

@notkspr
Copy link
Author

notkspr commented Apr 25, 2021

If you want easier customization, I would strongly recommend you to check out the starship prompt, which is basically the same but is cross-shell compatible and is configured with a config file, here's what mine looks like:

Screenshot from 2021-04-23 20-39-26

I will suggest that we add a similar prompt in Spaceship, users can change to show or no show the number of the changed files.
Please check the pull request for more details: #932

I will close the issue and continue the development work there.
Thank you!

@notkspr notkspr closed this as completed Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants