Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kotlin section #1292

Merged
merged 1 commit into from Nov 23, 2022
Merged

Added Kotlin section #1292

merged 1 commit into from Nov 23, 2022

Conversation

grimmyson
Copy link
Contributor

@grimmyson grimmyson commented Nov 14, 2022

Description

Resolves #1217

  • Added section for kotlin language
  • Fixed scala and lua tests cases

Screenshot

image

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for spaceship-prompt ready!

Name Link
🔨 Latest commit b1c1dbc
🔍 Latest deploy log https://app.netlify.com/sites/spaceship-prompt/deploys/63727be5beb6860009f77e01
😎 Deploy Preview https://deploy-preview-1292--spaceship-prompt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@grimmyson
Copy link
Contributor Author

grimmyson commented Nov 14, 2022

Could you please review the code and support me with a solution to the error in my test case with Ubuntu?
image

Local on mac tests had been passed:
image

@denysdovhan denysdovhan added the new-feature A PR that implement feature (section, specific behavior, etc). label Nov 23, 2022
@denysdovhan denysdovhan changed the title Added kotlin section Added Kotlin section Nov 23, 2022
@denysdovhan denysdovhan merged commit 592324b into spaceship-prompt:master Nov 23, 2022
@denysdovhan
Copy link
Member

Thanks for contributing!

@denysdovhan denysdovhan mentioned this pull request Nov 23, 2022
denysdovhan pushed a commit that referenced this pull request Nov 30, 2022
# [4.11.0](v4.10.1...v4.11.0) (2022-11-30)

### Bug Fixes

* improve version extraction ([23801f8](23801f8))
* **kotlin:** Check for extensions separately ([f631ae4](f631ae4))
* **kotlin:** Fix Kotlin version extraction ([a1681b4](a1681b4))

### Features

* **kotlin:** Added Kotlin section ([#1292](#1292)) ([592324b](592324b))
@denysdovhan
Copy link
Member

🎉 This PR is included in version 4.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@denysdovhan denysdovhan added the released Released issues and PRs label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A PR that implement feature (section, specific behavior, etc). released Released issues and PRs
Development

Successfully merging this pull request may close these issues.

Kotlin section
2 participants