fix,tests: Improve search for Pulumi.yml and Pulumi.yaml to prevent 'not found' message; Add tests for Pulumi section #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent 'not found' message; Add tests for Pulumi section
✅ Deploy Preview for spaceship-prompt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AndresMorelos
changed the title
denysdovhan
reviewed
Mar 22, 2024
| # Show PULUMI Stack when exists | ||
| local pulumi_project=$(spaceship::upsearch Pulumi.y*ml) | ||
| # Show PULUMI Stack when exist | ||
| local pulumi_project="$(spaceship::upsearch Pulumi.yml Pulumi.yaml)" |
There was a problem hiding this comment.
I think we should fix upsearch to work with globs.
denysdovhan
approved these changes
Mar 22, 2024
denysdovhan
pushed a commit
that referenced
this pull request
Mar 27, 2024
## [4.15.1](v4.15.0...v4.15.1) (2024-03-27) ### Bug Fixes * **pulumi:** Improve search for Pulumi.yml and Pulumi.yaml to prevent 'not found' message; Add tests for Pulumi section ([#1417](#1417)) ([134d979](134d979))
|
🎉 This PR is included in version 4.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
good bro good
Denys Dovhan ***@***.***>, 27 Mar 2024 Çar, 15:07 tarihinde
şunu yazdı:
… 🎉 This PR is included in version 4.15.1 🎉
The release is available on:
- npm package ***@***.*** dist-tag)
<https://www.npmjs.com/package/spaceship-prompt/v/4.15.1>
- GitHub release
<https://github.com/spaceship-prompt/spaceship-prompt/releases/tag/v4.15.1>
Your *semantic-release
<https://github.com/semantic-release/semantic-release>* bot 📦🚀
—
Reply to this email directly, view it on GitHub
<#1417 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM72X4YLWOKDC6BLCCJ2AYTY2KR5NAVCNFSM6AAAAABBP7N776VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRSGYYDSMRQGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the current version of the Pulumi section each time that I arrive at a folder without the Pulumi.y*ml file the console adds an unneeded message
spaceship_pulumi:6: no matches found: Pulumi.y*ml.On this PR I improved the Pulumi search file since YAML only has two possible extensions
.yml&.yaml; also I added test for this section.Screenshot
Tests passing