Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print GHC version instead of stack version #219

Merged
merged 5 commits into from
Mar 9, 2018
Merged

Print GHC version instead of stack version #219

merged 5 commits into from
Mar 9, 2018

Conversation

rteabeault
Copy link
Contributor

I think it would be more interesting to see the GHC version as opposed to the stack version for haskell projects.

@salmanulfarzy salmanulfarzy added the improvement A PR that make small changes for improving UX, performance, readability, etc label Sep 26, 2017
@salmanulfarzy
Copy link
Member

Why showing ghc version is more helpful ?

cc: @hariprasadkulkarni

@rteabeault
Copy link
Contributor Author

The version of the build tool is not as interesting. For example, if I am using ruby I don't need to see what version of rake I am using. I want to see the ruby version. Or if I am using java I don't want to see the version of maven or gradle. I want to see the java version. For the same reason I find the GHC version more interesting than the stack version.

@kulkarnih
Copy link
Contributor

@rteabeault Stack is released with a particular version of ghc. Using the stack version a user can get the version of both stack and ghc.

@rteabeault
Copy link
Contributor Author

@hariprasadkulkarni Stack is not pinned to a version of GHC. The version of stack does not indicate what version of GHC I am using for any given project.

@kulkarnih
Copy link
Contributor

OK. I'm fine with GHC then. But please change the README too.

And this still needs stack to be installed to show the GHC version.

@denysdovhan denysdovhan added the frozen Progress is temporarily frozen until resolving the specific issue. label Oct 19, 2017
@denysdovhan
Copy link
Member

I've added frozen label, since it's blocked by 3.0's breaking changes (see #148).

@salmanulfarzy salmanulfarzy removed the frozen Progress is temporarily frozen until resolving the specific issue. label Jan 20, 2018
@salmanulfarzy
Copy link
Member

@rteabeault 3.0 is out, Please update PR.

@denysdovhan
Copy link
Member

Thanks for contributing!

@denysdovhan denysdovhan merged commit 1e523c6 into spaceship-prompt:master Mar 9, 2018
@denysdovhan denysdovhan mentioned this pull request Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulkarnih kulkarnih kulkarnih approved these changes

@denysdovhan denysdovhan denysdovhan approved these changes

Assignees

@rteabeault rteabeault

Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rteabeault @salmanulfarzy @kulkarnih @denysdovhan