Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check for deactivate to detect a virtualenv #301

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Don't check for deactivate to detect a virtualenv #301

merged 1 commit into from
Jan 22, 2018

Conversation

segevfiner
Copy link
Contributor

Pipenv in fancy shell mode uses pew workon to activate the virtualenv which doesn't use the activate script, meaning the deactivate function is not defined and Spaceship fails to detect the virtualenv.

@salmanulfarzy salmanulfarzy mentioned this pull request Jan 4, 2018
Closed
@salmanulfarzy
Copy link
Member

salmanulfarzy commented Jan 4, 2018 •
edited

Thank you @segevfiner for the PR. Instead of creating duplicate PR you can change base branch of PR.

This looks good. Unfortunately 3.0 have been on the pipe for too long and our first priority is to release it. Any new PRs will be frozen until that.

Related #285

@salmanulfarzy salmanulfarzy added frozen Progress is temporarily frozen until resolving the specific issue. improvement A PR that make small changes for improving UX, performance, readability, etc labels Jan 4, 2018
@salmanulfarzy
Copy link
Member

salmanulfarzy commented Jan 19, 2018 •
edited

#148 is merged and v3.0.0 is out. Please, Update this PR corresponding to new changes.

@salmanulfarzy salmanulfarzy removed the frozen Progress is temporarily frozen until resolving the specific issue. label Jan 19, 2018
@segevfiner
Don't check for deactivate to detect a virtualenv
6e8d3a6 
Pipenv in fancy shell mode uses `pew workon` to activate the virtualenv
which doesn't use the activate script, meaning the deactivate function
is not defined and Spaceship fails to detect the virtualenv.
@segevfiner segevfiner changed the base branch from 3.0 to master January 19, 2018 13:33
@segevfiner
Copy link
Contributor Author

Rebased all my PR's

salmanulfarzy
salmanulfarzy approved these changes Jan 21, 2018
View reviewed changes
Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@salmanulfarzy salmanulfarzy changed the title [3.0] Don't check for deactivate to detect a virtualenv Don't check for deactivate to detect a virtualenv Jan 21, 2018
@salmanulfarzy salmanulfarzy merged commit d195f71 into spaceship-prompt:master Jan 22, 2018
@segevfiner segevfiner deleted the venv-no-deactivate-3.0 branch February 15, 2018 18:46
@salmanulfarzy salmanulfarzy mentioned this pull request Feb 26, 2018
Closed
@mozartilize
Copy link

As I remember that when you active virtualenv but then run exec zsh, the virtualenv still shows but actually is deactivated. I am the one who added deactivate command checking. Can someone plz double check?

@mozartilize
Copy link

actually the virtualenv still loaded but command deactivate doesn't exist anymore

@salmanulfarzy salmanulfarzy mentioned this pull request Jul 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan denysdovhan approved these changes

@salmanulfarzy salmanulfarzy salmanulfarzy approved these changes

Assignees

@salmanulfarzy salmanulfarzy

@segevfiner segevfiner

Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@segevfiner @salmanulfarzy @mozartilize @denysdovhan