Detect composer.json for php #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @el7cosmos for PR. But, All PRs are frozen until 3.0 release with #148. We can discuss this afterwards. |
salmanulfarzy
added
improvement
salmanulfarzy
removed
the
frozen
denysdovhan
requested changes
Feb 9, 2018
el7cosmos
force-pushed
the
php-composer
branch
from
24d84f0
to
81995bf
Compare
el7cosmos
force-pushed
the
php-composer
branch
from
81995bf
to
bab4301
Compare
|
Conflicts look like resolved ;) Will it be merged soon? |
salmanulfarzy
requested changes
Feb 28, 2018
There was a problem hiding this comment.
Sorry, We missed to follow up. Please also update the relevant section in doc
el7cosmos
force-pushed
the
php-composer
branch
from
a71b40e
to
aec14fb
Compare
salmanulfarzy
approved these changes
Feb 28, 2018
denysdovhan
approved these changes
Feb 28, 2018
|
@el7cosmos thanks for your contribution! Will be published ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.