-
-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change interpreter to zsh #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. For anyone looking for more info DashAsBinSh
I've renamed un/installers to use |
Interesting, do you remember how sourcing can be a problem? |
@maximbaz when you source these files you just stuck in the installation process forever. Every time you open a terminal it executes installation script. |
Not exactly sure how changing the interpreter fixes this, but maybe we can set |
I meant file extension. As for me, it's not okay, to have |
I honestly don't see this as a big deal, it's a shell script one way or another, just a different interpreter that is used to execute it. |
Description
Change interpreter in install/uninstall scripts to zsh, for issue #338
Could do bash instead, but I figure if you're installing a zsh theme you probably have zsh installed.