Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change interpreter to zsh #339

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

jgreat
Copy link
Contributor

@jgreat jgreat commented Jan 20, 2018

Description

Change interpreter in install/uninstall scripts to zsh, for issue #338

Could do bash instead, but I figure if you're installing a zsh theme you probably have zsh installed.

Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. For anyone looking for more info DashAsBinSh

@salmanulfarzy salmanulfarzy added the improvement A PR that make small changes for improving UX, performance, readability, etc label Jan 21, 2018
@denysdovhan
Copy link
Member

I've renamed un/installers to use sh, because some plugin managers (like zgen) have been sourcing these files. I'm afraid this PR may break the installation for some users.

@maximbaz
Copy link
Contributor

Interesting, do you remember how sourcing can be a problem?

@denysdovhan
Copy link
Member

@maximbaz when you source these files you just stuck in the installation process forever. Every time you open a terminal it executes installation script.

@maximbaz
Copy link
Contributor

Not exactly sure how changing the interpreter fixes this, but maybe we can set bash instead of sh ? Someone reported that bash also works, contrary to sh.

@denysdovhan
Copy link
Member

I meant file extension. zgen sources all files with zsh extension.

As for me, it's not okay, to have sh extension for file that is executed with zsh. It's like executing a file with py extension but using node interpreter.

@maximbaz
Copy link
Contributor

I honestly don't see this as a big deal, it's a shell script one way or another, just a different interpreter that is used to execute it.

@denysdovhan denysdovhan merged commit 9fbd89a into spaceship-prompt:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Development

Successfully merging this pull request may close these issues.

None yet

4 participants