-
-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add installation instructions for arch linux (from user repository) #372
add installation instructions for arch linux (from user repository) #372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
README.md
Outdated
@@ -148,6 +148,19 @@ Use this command in your `.zshrc` to load Spaceship as prompt theme: | |||
zplug denysdovhan/spaceship-prompt, use:spaceship.zsh, from:github, as:theme | |||
``` | |||
|
|||
### Linux package manager | |||
|
|||
#### Arch linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize Linux
🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kleinschmidt for maintaining the packages in AUR. I'm no Arch user, But I've few questions.
- AFAIK this won't update package on new releases, right ? Anyway we can add updates on new releases ?
Now there are two.spaceship
packages in AUR, Saw you mentioning about keepingspaceship-zsh-theme-git
atv2.11
. Wouldn't it be better to drop old package to avoid ambiguity ?spaceship-zsh-theme-git
have been merged tospaceship-prompt-git
in AUR.
@salmanulfarzy dropping the old package is my new plan (I've put in a request with the AUR authorities to merge it into the up-to-date one; it's not possible to rename an existing package). This will update on every commit to master (that's what the |
Just like @kleinschmidt said, proper package management tools take care of tracking pending updates on each new commit for |
Agreed, although that takes more effort on the part of the maintainer (either to set up something to automatically track the releases, or to remember to update the PKGBUILD file with the new version info automatically). In any case, I have a local copy of this that's pegged to a specific version so if someone'e interested in maintaining that I'm happy to hand it off... |
Oh.. Then cool, I just glanced through update process on Arch wiki. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting suggestion
README.md
Outdated
#### Arch Linux | ||
|
||
Install the latest master from the [AUR package | ||
`spaceship-prompt-git`](https://aur.archlinux.org/packages/spaceship-prompt-git/): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these are on separate lines ? Would be better if they're on the same line and linked only to spaceship-prompt-git
,
-Install the latest master from the [AUR package
-`spaceship-prompt-git`](https://aur.archlinux.org/packages/spaceship-prompt-git/):
+Install the latest master from the AUR package [`spaceship-prompt-git`](https://aur.archlinux.org/packages/spaceship-prompt-git/):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, my editor wraps at 80 characters and I didn't notice that there are long lines elsewhere. I'm fine with that linking change too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Description
This adds a pointer the README to the arch linux package spaceship-prompt-git along with instructions for installing it manually (should be familiar to an arch user).