Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape comments while checking duplicate prompt installation #390

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Escape comments while checking duplicate prompt installation #390

merged 1 commit into from
Mar 29, 2018

Conversation

Runrioter
Copy link
Member

Filter comments out to make installing smoothly.

Description

I commented some command somehow, but didn't rollback it back 馃槶

@Runrioter
improve install.sh
5201304 
Filter comments out to make installing smoothly (I commented some command somehow, but didn't rollback it back)
@Runrioter
Copy link
Member Author

OK, maybe this is unnecessary

@Runrioter Runrioter closed this Mar 13, 2018
@Runrioter Runrioter deleted the patch-1 branch March 13, 2018 14:43
@salmanulfarzy
Copy link
Member

salmanulfarzy commented Mar 13, 2018 •
edited

Sorry @Runrioter, I misunderstood the cause 馃檹

This escapes comments while parsing $ZSHRC to check whether spaceship-prompt is enabled, Right ?

Edit: I misunderstood the cause and reviewed. By the time I understood my mistake and roll-backed review, @Runrioter closed the PR.

@Runrioter
Copy link
Member Author

@salmanulfarzy Yes, right

@Runrioter Runrioter restored the patch-1 branch March 13, 2018 14:46
@salmanulfarzy
Copy link
Member

salmanulfarzy commented Mar 13, 2018 •
edited

Do you mind restoring the branch, We could keep the discussion on.

@salmanulfarzy salmanulfarzy reopened this Mar 13, 2018
@salmanulfarzy salmanulfarzy added the improvement A PR that make small changes for improving UX, performance, readability, etc label Mar 13, 2018
@maximbaz
Copy link
Contributor

This ignores the comments, so previously if you had spaceship commented out, install.sh would think that spaceship is enabled and will not re-enable it, with this PR it will ignore comments and thus add spaceship configuration again.

I think it's a good PR.

@salmanulfarzy salmanulfarzy changed the title improve install.sh Escape comments while checking duplicate prompt installation Mar 13, 2018
@Runrioter
Copy link
Member Author

@salmanulfarzy @maximbaz Yes, you got it. Sorry, I am not a native-english speaker.

salmanulfarzy
salmanulfarzy approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 馃憤

@Runrioter
Copy link
Member Author

@salmanulfarzy @maximbaz merge this ?

@salmanulfarzy
Copy link
Member

This is good to go. Anything else @denysdovhan ?

@denysdovhan
Copy link
Member

@salmanulfarzy LGTM

@denysdovhan denysdovhan merged commit 5a391a5 into spaceship-prompt:master Mar 29, 2018
@Runrioter Runrioter deleted the patch-1 branch March 29, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan denysdovhan approved these changes

@salmanulfarzy salmanulfarzy salmanulfarzy approved these changes

Assignees
No one assigned
Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Runrioter @salmanulfarzy @maximbaz @denysdovhan