Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were two issues with PHP version formatting I found. First, more importantly, was that
PHP
substring itself was matched aftergrep
pingphp -v
. When I execute php -v, there are some warnings however, such as:These warnings are also matched, and then,
awk
prints out empty lines. I fixed the pattern so that the version number is not optional.Also, I added a space before version number, so that it is more consistent (see Node version in the same screenshot).
Screenshot
Before:
After: