modify declaration of dir variable in sections/dir #421
Conversation
There was a problem hiding this comment.
Unable to reproduce the issue.
Edit: There was a mistake from my side during earlier reproducing attempts. This is reproducible and affects every unassigned initialized variables, Which have global alias defined with user configuration.
salmanulfarzy
added
the
improvement
There was a problem hiding this comment.
This is good to go 👌
@gurpreetatwal do you consider to address the similar variable assignments ? If not, We could merge this.
sections/dir.zsh
Outdated
| @@ -21,7 +21,7 @@ SPACESHIP_DIR_COLOR="${SPACESHIP_DIR_COLOR="cyan"}" | |||
| spaceship_dir() { | |||
| [[ $SPACESHIP_DIR_SHOW == false ]] && return | |||
|
|
|||
| local dir | |||
| local 'dir' | |||
There was a problem hiding this comment.
Please leave a comment about using quotes here.
There was a problem hiding this comment.
This should be default behavior for all unassigned local variables. Documenting it in doc would be better than leaving a single comment.
- explicitly assigning the variable prevents it accidentally expanding the dir variable if there is a shell alias assigned to it
as suggested in #420 (comment) fix #420
|
@denysdovhan @salmanulfarzy rebased and cleaned up the PR
|
| @@ -27,7 +27,7 @@ spaceship_venv() { | |||
| # Check if the current directory running via Virtualenv | |||
| [ -n "$VIRTUAL_ENV" ] || return | |||
|
|
|||
| local venv | |||
| local 'venv' | |||
There was a problem hiding this comment.
I could see this as being troublesome as well
example:
alias -g venv='python3 -m venv'
modify declaration of dir variable in sections/dir
Description
potential fix for #420, feel free to close this PR if a better solution can be found
Fixes the issue by explicitly assigning the variable to prevent it from accidentally expanding the dir variable if there is a shell alias assigned to it.
Fix #420