Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api doc #425

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Conversation

ellaqezi
Copy link
Contributor

Description

Update the example section in API.md so that the checks for existing command is executed before further checks.

Screenshot

image

salmanulfarzy
salmanulfarzy previously approved these changes Apr 23, 2018
Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Looks like commits are not attributed to your GitHub profile properly. Could you please check your gitconfig and verify everything is correct ?

api doc user profile incorrect

@ellaqezi
Copy link
Contributor Author

image

  • correct commit's author

@salmanulfarzy I now corrected my user entries in gitconfig

@salmanulfarzy salmanulfarzy merged commit d1599e3 into spaceship-prompt:master Apr 24, 2018
@salmanulfarzy
Copy link
Member

Thank you for contributing @ellaqezi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants