Use POSIX sed to upgrade version of spaceship #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed -i isn't POSIX compliant and behaves differently on BSD and GNU flavours of sed BSD sed -i expects an extension after space. While this extension is optional on GNU sed and must be on the same argument without any intervening space. This breaks cross compatibility of script.
10 tasks
salmanulfarzy
changed the title
denysdovhan
approved these changes
Sep 28, 2018
Merged
dedene
pushed a commit
to zenjoy/spaceship-prompt
that referenced
this pull request
Feb 24, 2019
`sed -i` isn't POSIX compliant and behaves differently on BSD `sed` and GNU `sed`. BSD `sed` with `-i` expects an extension after space. While this extension is optional on GNU `sed` and must be on the same argument without any intervening space. This breaks cross compatibility of script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sed -iisn't POSIX compliant and behaves differently on BSDsedand GNUsed.BSD
sedwith-iexpects an extension after space. While this extension is optional on GNUsedand must be on the same argument without any intervening space. This breaks cross compatibility of script.We could either use
perlfor in-place file editing or do whatseddoes behind the screens.Also affects uninstall script,
https://github.com/denysdovhan/spaceship-prompt/blob/fbe6ec5f090baa696b884228b4063c874b8c3a1a/scripts/uninstall.sh#L83-L88