-
-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add space after kubecontext symbol #432
Conversation
The existing symbol seems to cover the existing space This commit simply adds another space to format the prompt better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @deploymentking for your PR. But there is already a space after kubecontext
symbol (note ·
in kubecontext
options).
This might be an issue with your terminal emulator character width settings. Alternate solution is to use double space after symbol in your configuration.
I see the same issue with all the Powerline fonts on OSX. I think maybe the extra space is needed because the emoji for the wheel is much bigger than the other emojis. ☸️ |
Confirmed. I have correct setup for character width, but ☸️ overlaps with the section's content. @salmanulfarzy I think we can merge it with notice comment. Of course, it's gonna be removed as soon as it'll look better natively. |
I think it is a bug in your terminal guys, it looks perfectly for me with one space in kitty terminal. Default (two spaces) vs my config with one space. |
The existing symbol seems to cover the existing space
This commit simply adds another space to format the prompt better
Thanks for you pull-request!
Please, make sure you've read CONTRIBUTING.md before submitting this PR.
Description
I love the theme but the lack of space between the kubecontext symbol and the text really seemed to stick out
Screenshot
Please, attach a screenshot, if possible.