Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space after kubecontext symbol #432

Merged
merged 2 commits into from
May 18, 2018

Conversation

deploymentking
Copy link
Contributor

@deploymentking deploymentking commented Apr 30, 2018

The existing symbol seems to cover the existing space
This commit simply adds another space to format the prompt better

Thanks for you pull-request!
Please, make sure you've read CONTRIBUTING.md before submitting this PR.

Description

I love the theme but the lack of space between the kubecontext symbol and the text really seemed to stick out

Screenshot

Please, attach a screenshot, if possible.

before
after

The existing symbol seems to cover the existing space
This commit simply adds another space to format the prompt better
Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @deploymentking for your PR. But there is already a space after kubecontext symbol (note · in kubecontext options).

This might be an issue with your terminal emulator character width settings. Alternate solution is to use double space after symbol in your configuration.

@jakepearson
Copy link

I see the same issue with all the Powerline fonts on OSX. I think maybe the extra space is needed because the emoji for the wheel is much bigger than the other emojis. ☸️

@denysdovhan
Copy link
Member

Confirmed.

I have correct setup for character width, but ☸️ overlaps with the section's content.

@salmanulfarzy I think we can merge it with notice comment. Of course, it's gonna be removed as soon as it'll look better natively.

@denysdovhan denysdovhan added the improvement A PR that make small changes for improving UX, performance, readability, etc label May 18, 2018
@denysdovhan denysdovhan merged commit 5711164 into spaceship-prompt:master May 18, 2018
@maximbaz
Copy link
Contributor

I think it is a bug in your terminal guys, it looks perfectly for me with one space in kitty terminal.

Default (two spaces) vs my config with one space.

image

maximbaz added a commit to maximbaz/spaceship-prompt that referenced this pull request May 29, 2018
@maximbaz maximbaz mentioned this pull request May 29, 2018
maximbaz added a commit to maximbaz/spaceship-prompt that referenced this pull request Jun 9, 2018
rolling-space pushed a commit to rolling-space/spaceship-prompt that referenced this pull request Jan 31, 2019
maximbaz added a commit to maximbaz/spaceship-prompt that referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Development

Successfully merging this pull request may close these issues.

None yet

5 participants