Add options to change secondary and/or root prompt chars

[Darkhogg]

Description

Add two config variables to control the prompt character for secondary prompts and for the root user:

• SPACESHIP_CHAR_SYMBOL_ROOT to change the root prompt
• SPACESHIP_CHAR_SYMBOL_SECONDARY to change the seondary prompt

Both default to $SPACESHIP_CHAR_SYMBOL, so this change should not alter the current behaviour and not affect any users that don't change those vars.

Screenshot

With the following config:

SPACESHIP_CHAR_SYMBOL='$ '
SPACESHIP_CHAR_SYMBOL_ROOT='# '
SPACESHIP_CHAR_SYMBOL_SECONDARY='> '

I get the following prompts

(I also have all of them configured with the same color, but otherwise the regular color configuration is maintained)

[salmanulfarzy]

Thanks @Darkhogg for PR. Let me try to address these changes from my perspective,

• user section already alerts on user switching as root.
• Secondary prompt is displayed with different color than primary prompt with is configurable via SPACESHIP_CHAR_COLOR_SECONDARY

So I would not favor this changes, But leaving this open for more discussion.

[Darkhogg]

Let me address your points specifically:

• people might want to disable the user section but still have a way of identifying whether they're root or not. This is actually the default and I'd say expected behaviour for most if not all shells.
• The color change of the secondary prompt can be non obvious, and again it being different it's the default and possibly expected behaviour for most shells.

As an "extremely customizable theme" (direct quote from the README), the ability to select how you want the prompt characters to look I think is a basic one, especially when it's something most shells already do out of the box. It's ok if you don't agree, but know that there's at least one user (me) that's using a fork instead of upstream primarily so these customizations are available.

[maximbaz]

I think it's an interesting PR and is worth merging, one scenario where this would be useful is copy-paste, where colors are lost, but everyone is familiar with the conventional meaning of chars $, # and > in the prompt.

[salmanulfarzy]

LGTM

[salmanulfarzy]

As an "extremely customizable theme" (direct quote from the README)

We try to find the balance between being customizable and not to confuse users with too many options. That's why we try to think twice before adding new options and sections.

one scenario where this would be useful is copy-paste, where colors are lost, but everyone is familiar with the conventional meaning of chars $, # and > in the prompt.

Thanks @maximbaz, Didn't immediately think of that.

[salmanulfarzy]

Thank you for contributing @Darkhogg