Center title and links in README #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmanulfarzy
added
improvement
matchai
reviewed
Aug 28, 2018
README.md
Outdated
| > A [Zsh][zsh-url] prompt for Astronauts. | ||
| <div align="center"> | ||
| <h4> | ||
| <a href="https://denysdovhan.com/spaceship-prompt/">Website |</a> |
There was a problem hiding this comment.
I would suggest removing the | dividers from the <a> tags. The underline behavior is unexpected with the dividers within the tag.
10 tasks
denysdovhan
approved these changes
Sep 7, 2018
salmanulfarzy
added a commit
that referenced
this pull request
Sep 7, 2018
Center title and links in README
|
Could you also check #396 ? Our documentation on website haven't updated in the last several months. Anything that I could to get that merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to improve accessibility of documentation and better UI. But, this comes at cost of including
HTMLdirectly insidemarkdowndue to limitations ofmarkdownsyntax and affects readability ofREADME.Included Changes
|)Direct link to branch page: salmanulfarzy/spaceship-prompt@center-doc
Before
After