Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution instructions #509

Merged

Conversation

merikan
Copy link
Contributor

@merikan merikan commented Sep 11, 2018

Description

Tests could not be run after cloning the repository because submodules (shunit2) were not initialized.
modules/shunit2/shunit2:source:100: no such file or directory: modules/shunit2/shunit2

Added instructions in the contribution document how to update submodules.

Tests could not be run after cloning the repository because submodules were not initialized
@salmanulfarzy salmanulfarzy added the docs Issue or PR is related to documentation. label Sep 11, 2018
Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @merikan

@salmanulfarzy salmanulfarzy merged commit 35ac6cd into spaceship-prompt:master Sep 11, 2018
dedene pushed a commit to zenjoy/spaceship-prompt that referenced this pull request Feb 24, 2019
@merikan merikan deleted the feature/update_contribution_doc branch September 12, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issue or PR is related to documentation.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants