Use AWS_PROFILE variable for aws named profiles

[RolfKoenders]

Description

Refactor the AWS section to use the correct environment variable that the (new) AWS cli uses. Its using named profiles.

Fixes #259

[salmanulfarzy]

Thank you @RolfKoenders for the PR 👍

I don't use AWS, But is there any cases where removing AWS_DEFAULT_PROFILE misses valid configurations from prompt ?

It would be better if this change was documented under AWS section.

[RolfKoenders]

Since the AWS_DEFAULT_PROFILE var is completely removed from the awscli i don't expect that to happen. The link in the aws section which links to the documentation of the cli explains this new AWS_PROFILE var.

[salmanulfarzy]

Looks like AWS_PROFILE is the recommended solution with backward support for AWS_DEFAULT_PROFILE. Since the changes was introduced more than a year ago in aws-cli, It shouldn't be a problem.

[RolfKoenders]

@salmanulfarzy Thanks for updating the documentation! 👍

[salmanulfarzy]

Code looks good 👍 But we need review from someone who use the section regularly.

[RolfKoenders]

Maybe @cdimitroulas or @robertomoreno can help us out here. ping 😉

[cdimitroulas]

I've been using spaceship with the exact same code change as this PR for a long time and it works great (I know I know... super guilty that I didn't make the PR myself!)

From my perspective this is good to be merged

[salmanulfarzy]

Merged, Thank you @RolfKoenders @cdimitroulas 👏