Fix "bad math expression" for battery with UPS #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #245 `spaceship_battery:56: bad math expression: operator expected at '100'` if multiple battery statuses are reported (on macOS, at least). Happens when pmset reports secondary charge due to UPS.
|
@denysdovhan any chance you could take a look? |
salmanulfarzy
added
improvement
denysdovhan
approved these changes
Nov 19, 2018
|
Sorry missed this PR. LGTM. The code looks cleaner. @salmanulfarzy do you approve? |
|
Code looks good. Haven't tested this, But if this doesn't break anything, then 👍 |
We need to cover this section with tests. It's stupid to hope that nothing was broken. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
spaceship_battery:56: bad math expression: operator expected at '100'if multiple battery multiple are reported (on macOS, at least).Happens when pmset reports secondary charge due to UPS.
Instead of only testing for existence of "InternalBattery" in
pmset -g battresult, will filter this row from the beginning so no other charges are combined into the result.