Kubernetes namespace display can be turned off #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximbaz
approved these changes
Nov 30, 2018
|
I forgot to update the documentation, will be done in a moment. Update: Done :) |
salmanulfarzy
approved these changes
Nov 30, 2018
There was a problem hiding this comment.
We did have discussion about this (898abaa) and here you are 👍
salmanulfarzy
added
the
improvement
|
There was issues with publishing v3.8.1 earlier, Corresponding commit wasn't pushed because of branch protection. This can be merged as soon as it's resolved. Update: Release issue have been resolved. Merging this. |
denysdovhan
reviewed
Dec 1, 2018
| @@ -479,6 +479,7 @@ Shows the active kubectl context, which consists of a cluster name and, when wor | |||
| | `SPACESHIP_KUBECONTEXT_SUFFIX` | `$SPACESHIP_PROMPT_DEFAULT_SUFFIX` | Suffix after Kubectl context section | | |||
| | `SPACESHIP_KUBECONTEXT_SYMBOL` | `☸️·` | Character to be shown before Kubectl context | | |||
| | `SPACESHIP_KUBECONTEXT_COLOR` | `cyan` | Color of Kubectl context section | | |||
| | `SPACESHIP_KUBECONTEXT_NAMESPACE_SHOW` | `true` | Should namespace be also displayed | | |||
There was a problem hiding this comment.
We need rules for naming new options. Add a section in CONTRIBUTING.md.
dedene
pushed a commit
to zenjoy/spaceship-prompt
that referenced
this pull request
Feb 24, 2019
zachliu
pushed a commit
to zachliu/spaceship-prompt
that referenced
this pull request
Oct 25, 2019
denysdovhan
pushed a commit
that referenced
this pull request
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a config flag to the
kubecontextsection to control whether namespace is displayed or not.By default, original behavior is conserved and display is on.
By setting
SPACESHIP_KUBECONTEXT_NAMESPACE_SHOW=falsein .zshrc it is possible to get rid of this display in case namespace is not something one is interested in. This also avoids runningkubectl config view --minify --output 'jsonpath={..namespace}'command.Screenshot