Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker version bug #582

Merged
merged 1 commit into from
Dec 5, 2018
Merged

fix: docker version bug #582

merged 1 commit into from
Dec 5, 2018

Conversation

popmoore
Copy link
Contributor

@popmoore popmoore commented Dec 5, 2018

@Runrioter
Copy link
Member

Version format: 18.06.1 or 18.06.1-ce

salmanulfarzy
salmanulfarzy approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@salmanulfarzy salmanulfarzy added the improvement A PR that make small changes for improving UX, performance, readability, etc label Dec 5, 2018
@salmanulfarzy salmanulfarzy merged commit c092d09 into spaceship-prompt:master Dec 5, 2018
@salmanulfarzy
Copy link
Member

salmanulfarzy commented Dec 5, 2018 •
edited
Loading

So GitHub makes PR author as committer author while squashing, Even though it was created from other users repository ?! 🤔 Sorry @Runrioter !

Thank you @LockedOutofHeaven 👍

@maximbaz
Copy link
Contributor

maximbaz commented Dec 5, 2018

@salmanulfarzy Github sets original author as author and you as committer, this is expected because it was you who committed the change in master 😉

@denysdovhan
Copy link
Member

Everything is fine:

screen shot 2018-12-05 at 23 49 10

@Runrioter
Copy link
Member

@salmanulfarzy Never mind. It's fine. 😉

@salmanulfarzy
Copy link
Member

Github sets original author as author and you as committer,

Made a mistake in above comment, corrected now.

original author as author

So who's the original author here, One who made the commits or the pull request author ? 🤔

This pull request was created by @LockedOutofHeaven from fork of @Runrioter. So shouldn't he be also credited as author automatically ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysdovhan denysdovhan denysdovhan approved these changes

@salmanulfarzy salmanulfarzy salmanulfarzy approved these changes

Assignees
No one assigned
Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@popmoore @Runrioter @salmanulfarzy @maximbaz @denysdovhan