Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the local server from the real dispatcher server #2

Open
chaos-adept opened this issue May 15, 2018 · 4 comments
Open

Replace the local server from the real dispatcher server #2

chaos-adept opened this issue May 15, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@chaos-adept
Copy link
Member

currently, implementation makes an instance of the dispatcher server and attach clients from the https://github.com/spaceshipyard/mars-rover-dispatcher/tree/master/client

it should be replaced by making a client connection to the https://github.com/spaceshipyard/mars-rover-dispatcher/tree/master/server

@chaos-adept chaos-adept added the enhancement New feature or request label May 15, 2018
@vlfors
Copy link
Collaborator

vlfors commented May 28, 2018

it should be replaced by making a client connection to the https://github.com/spaceshipyard/mars-rover-dispatcher/tree/master/server

Could you clear up? "server" recalculate and resend data to robot?
Which commands it is using for it?

@chaos-adept
Copy link
Member Author

@vlfors i have not seen you comment for some reasons, could you confirm that this question was resolved already?

@vlfors
Copy link
Collaborator

vlfors commented Jun 4, 2018

In general I understood, but I have watched code in https://github.com/spaceshipyard/mars-rover-dispatcher/tree/master/server, server is not resending messages. It is making only responses .

@chaos-adept
Copy link
Member Author

@vlfors
Actually, it is not required to resending messages, it just sends messages to the channel
https://github.com/spaceshipyard/mars-rover-dispatcher/blob/master/server/index.js#L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants