Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors with treating astropy_helpers as a submodule #106

Merged
merged 8 commits into from Nov 11, 2020

Conversation

york-stsci
Copy link
Collaborator

This should eliminate errors caused by treating astropy_helpers as a submodule instead of using the system version.

Closes #93

@york-stsci york-stsci added this to the 1.0.9 milestone Oct 13, 2020
@robelgeda
Copy link
Collaborator

There is a lot going on in this PR, I am not sure if the changes to the util functions is related to the astropy helper issue? @york-stsci

@york-stsci
Copy link
Collaborator Author

The changes in util functions were, I think, required to make the tests pass. I don't know why that was, but I don't think they're a part of the astropy helper issue.

@york-stsci york-stsci merged commit e14f6e0 into spacetelescope:master Nov 11, 2020
@york-stsci york-stsci deleted the astropy_fix branch November 11, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.py does not find installed astropy_helpers
2 participants