Update STIPS infrastructure to remove astropy_helpers #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because astropy_helpers is now deprecated, it should be removed at some point. This is that point. This iteration of STIPS replaces astropy_helpers with tox.
Also, it can be challenging to make sure all of the data directories are set up (as encountered when setting up tox). This version of STIPS also adds two utility functions, SetupDataPaths and DownloadReferenceData. The first sets any un-set environment variables. The second downloads reference data to the appropriate paths (whether set by SetupDataPaths or not). The stips init.py file now uses the first of these, and tox uses the second. Note that DownloadReferenceData calls SetupDataPaths.