Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #28

Merged
merged 11 commits into from Jan 13, 2020
Merged

Error handling #28

merged 11 commits into from Jan 13, 2020

Conversation

ceb8
Copy link
Collaborator

@ceb8 ceb8 commented Dec 20, 2019

Adding error handling so that if one file in a list for fits_cut or image_cut raises an error, the user still gets a cutout with the rest of the files. A warning is raised showing which files caused a problem and what the error was.

@ceb8 ceb8 added this to the 0.5 milestone Dec 20, 2019
@ceb8
Copy link
Collaborator Author

ceb8 commented Dec 20, 2019

This PR also addresses some of the smaller issues from #16.

@ceb8
Copy link
Collaborator Author

ceb8 commented Dec 20, 2019

This PR also addresses #26.

@ceb8
Copy link
Collaborator Author

ceb8 commented Jan 13, 2020

This PR also updates the fits handling to use with fits.open() syntax so that fits files will be properly closed if an error is raised while they are in use.

@ceb8 ceb8 merged commit 7ff4438 into master Jan 13, 2020
@ceb8 ceb8 deleted the error_handling branch January 13, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant