-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large HAP catalogs still being rejected #1723
Comments
Comment by Rick White on JIRA: Example visits that show the problem:
The trailer file
The result is that the segment catalog is rejected. The clue to the fix is in step 2. Note that the total source fraction there is large, but that is not identified as a reason to reject that version of the catalog. That is because line 1668 of catalog_utils.py specifies the parameter Using The fix for this issue is to use that same parameter in the call to |
Comment by Michele De La Pena on JIRA: In a test branch, I had already modified some criteria potentially to allow for more segmentation catalogs to be generated. Having tested this recommended change and found it to be better than one of the changes I was contemplating, I intend to include this update in the next release of drizzlepac. Testing with hst_11911_01_wfc3_uvis_total_ibc301_trl.txt. Output messages will be updated to reflect properly the state of the associated processing. |
Comment by Rick White on JIRA: Sounds good! Sorry I've been slow responding to comments, but this sounds like a good plan. If there is a test version of the data you'd like me to look at, let me know. |
Comment by Michele De La Pena on JIRA: Officially closing this ticket as additional testing and evaluation of this fix, as well as other fixes are handled by HLA-1079. |
Issue HLA-1187 was created on JIRA by Rick White:
In the latest version of the pipeline processing (using DrizzlePac 3.6.2), large segment catalogs are still being rejected for having too many sources. This was addressed by ticket HLA-1004 (see also HLA-1079) but apparently has not been fixed yet.
I believe there is a simple fix: set
check_big_island_only=True
in the final call todetect_and_eval_segments()
on line 1773 of catalog_utils.py.Examples and further discussion are in the comments below.
The text was updated successfully, but these errors were encountered: